Contributed by phessler on from the <b>everyone</b>-uses-UFS dept.
"this present diff fixes two races currently in our ufs_rename() code, both due to failed node lookups, in which cases we should not carry on with the rename process, the problem being more easily triggered in the presence of many similar renames happening simultaneously, a behaviour busy postfix servers seem to expose quite commonly, as can be seen by the PRs 4040 and 4126, whose submitters have been already running with this fix for a while, both having reported success, and PR 4169 as well.
in addition, this diff also addresses a reference that was being lost in ufs_checkpath() and optimizes a if/else's logical structure. the fix for the two relevant problems were taken from netbsd.
ufs_rename() is tricky, any change to it requires much testing, so that we can keep openbsd's -current code quality. so, in a sentence, in case you're an openbsd user and happen to accidentally have a ufs partition laying around and to use it for some weird reason, you should test this.
jokes aside, this kind of user seems to be getting more and more hard to find everyday, so please don't lose this opportunity to prove you're one of them."
(Comments are closed)