OpenBSD Journal

UFS patch from Pedro

Contributed by phessler on from the <b>everyone</b>-uses-UFS dept.

Pedro Martelletto is asking anyone that uses ufs, to test a diff he sent to tech@ Pedro writes:

"this present diff fixes two races currently in our ufs_rename() code, both due to failed node lookups, in which cases we should not carry on with the rename process, the problem being more easily triggered in the presence of many similar renames happening simultaneously, a behaviour busy postfix servers seem to expose quite commonly, as can be seen by the PRs 4040 and 4126, whose submitters have been already running with this fix for a while, both having reported success, and PR 4169 as well.

in addition, this diff also addresses a reference that was being lost in ufs_checkpath() and optimizes a if/else's logical structure. the fix for the two relevant problems were taken from netbsd.

ufs_rename() is tricky, any change to it requires much testing, so that we can keep openbsd's -current code quality. so, in a sentence, in case you're an openbsd user and happen to accidentally have a ufs partition laying around and to use it for some weird reason, you should test this.

jokes aside, this kind of user seems to be getting more and more hard to find everyday, so please don't lose this opportunity to prove you're one of them.

(Comments are closed)

  1. By Anonymous Coward ( on

    Pedro for President!

    1. By Anonymous Coward ( on

      Pedro: Do you think people will vote for me?
      Napoleon Dynamite: Heck yes! I'd vote for you.
      Pedro: Like what are my skills?
      Napoleon Dynamite: Well, you have a sweet bike. And you're really good at hooking up with chicks. Plus you're like the only guy at school who has a mustache. 
      Pedro: Vote for me, and all your wildest dreams will come true.
      * Napoleon Dynamite

    2. By Anonymous Coward ( on

      Napolean Dynamite: Pedro offers you his protection.

      Deb: Are they still letting you run for president?
      Pedro: Yes. I don't understand... they say you're not allowed to have pinatas that look like real people, but in Mexico, we do it all the time.

      Pedro: If I win, you can be my secretary or something.
      Napoleon Dynamite: Sweet!




Copyright © - Daniel Hartmeier. All rights reserved. Articles and comments are copyright their respective authors, submission implies license to publish on this web site. Contents of the archive prior to as well as images and HTML templates were copied from the fabulous original with Jose's and Jim's kind permission. This journal runs as CGI with httpd(8) on OpenBSD, the source code is BSD licensed. undeadly \Un*dead"ly\, a. Not subject to death; immortal. [Obs.]